Skip to content

Load community cache before serverbrowser uses it #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SollyBunny merged 1 commit into from
Jan 17, 2026
Merged

Load community cache before serverbrowser uses it #173

SollyBunny merged 1 commit into from
Jan 17, 2026
+3 −0

Conversation

@qxdFox
Copy link

@qxdFox qxdFox commented Jan 16, 2026

I've been using this on my client and it's been working, haven't had any issues

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)
  • I didn't use generative AI to generate more than single-line completions
  • Don't care about checkboxes

@qxdFox
Copy link
Author

qxdFox commented Jan 16, 2026

This should close SollyBunny/ddnet-custom-communities#31, not sure

@qxdFox
Copy link
Author

qxdFox commented Jan 16, 2026

and https://discord.com/channels/957377260833366116/1423328979632394301/1423328979632394301, I think

@SollyBunny
Copy link
Collaborator

SollyBunny commented Jan 17, 2026

I don't see how this helps, but it also shouldn't do any harm

@SollyBunny SollyBunny merged commit b5ca9db into TaterClient:master Jan 17, 2026
12 of 14 checks passed
@SollyBunny SollyBunny mentioned this pull request Jan 17, 2026
Open
@qxdFox
Copy link
Author

qxdFox commented Jan 17, 2026 •
edited
Loading

The issue is that the communities arent loaded fast enough, loading them from the file in OnConsoleInit() loads them before any of the community commands can be used, which would clean any (at that point) unknown community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qxdFox @SollyBunny